net: openthread: rpc: Align input line buffer with openthread config

Make buffer global for high value of CONFIG_OPENTHREAD_CLI_MAX_LINE_LENGTH to prevent stack overflow. The second solution would be increasing CONFIG_NRF_RPC_THREAD_STACK_SIZE but this increases stack buffer for each rpc thread pool. The approach can be optimize in future by implementing packet fragmentation. Signed-off-by: Lukasz Maciejonczyk <[email protected]>
nrfconnect · Nov 13, 2024 · 10bf753 · 10bf753
1 parent a9732b6
commit 10bf753
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/subsys/net/openthread/rpc/server/ot_rpc_cli.c b/subsys/net/openthread/rpc/server/ot_rpc_cli.c
@@ -68,10 +68,14 @@ NRF_RPC_CBOR_CMD_DECODER(ot_group, ot_rpc_cmd_cli_init, OT_RPC_CMD_CLI_INIT, ot_
 static void ot_rpc_cmd_cli_input_line(const struct nrf_rpc_group *group,
 				      struct nrf_rpc_cbor_ctx *ctx, void *handler_data)
 {
-	char input_line_buffer[256];
 	struct nrf_rpc_cbor_ctx rsp_ctx;
 	char *result;
 
+#if CONFIG_OPENTHREAD_CLI_MAX_LINE_LENGTH > 256
+	static
+#endif
+		char input_line_buffer[CONFIG_OPENTHREAD_CLI_MAX_LINE_LENGTH - 1];
+
 	/* Parse the input */
 	result = nrf_rpc_decode_str(ctx, input_line_buffer, sizeof(input_line_buffer));