Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PlatformMgr().Shutdown() for NRF53 #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bdlr2
Copy link

@bdlr2 bdlr2 commented Feb 19, 2024

Linked to my case on the DevZone https://devzone.nordicsemi.com/f/nordic-q-a/108101/device-crash-when-doing-a-software-reset

When calling the function PlatformMgr().Shutdown(); (intentionally, or through a factory reset) a Hard Fault happens because the communication is broken/not in sync anymore between the App and Net cores of the NRF5340. My fix proposes to first reset the network core then reset the application core.

@bdlr2 bdlr2 changed the title Added network core reset for the NRF53 when calling PlatformMgr::Shut… Fixed PlatformMgr().Shutdown() for NRF53 Feb 19, 2024
@LuDuda LuDuda added the DNM label Feb 20, 2024
Copy link
Collaborator

@LuDuda LuDuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bdlr2,

Thank you for your contribution.

I believe we should not need to call nrf_reset_network_force_off in the Matter platform, as this should be handled internally by sys_reboot.

Have you encountered this issue on the nRF5340DK, or only on a custom board? If I had to guess, it's possible you've designed your own board and the nrf5340_cpunet_reset.c file has not been included in board's CMakeLists.txt. You can find an example here (note the if-statement): nRF5340DK CMakeLists.txt.

@bdlr2
Copy link
Author

bdlr2 commented Mar 21, 2024

Hello @LuDuda, thanks for the feedback.
That's indeed on a custom board, but I double checked and the nrf5340_cpunet_reset.c is included properly in the CMakelists.txt. My board was derived from the nRF5340DK to avoid this kind of issues.

@LuDuda
Copy link
Collaborator

LuDuda commented Oct 9, 2024

Hello @LuDuda, thanks for the feedback. That's indeed on a custom board, but I double checked and the nrf5340_cpunet_reset.c is included properly in the CMakelists.txt. My board was derived from the nRF5340DK to avoid this kind of issues.

@bdlr2 Have you been able to check the newest SDK if the problem still exists? As i mentioned above, I would like to fix this issue outside of the Matter code.

@bdlr2
Copy link
Author

bdlr2 commented Oct 10, 2024

@LuDuda no, I didn't check yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants