add semtech to app index #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbober
reviewed
Aug 27, 2024
index/dudmuck.json
Outdated
There was a problem hiding this comment.
Should this file be named "semtech.json"?
There was a problem hiding this comment.
As @wbober mentioned, this file should be named "semtech.json".
wbober
previously approved these changes
Aug 27, 2024
FilipZajdel
requested changes
Aug 27, 2024
index/dudmuck.json
Outdated
| "FSK" | ||
| ], | ||
| "compatibleNcs": [ | ||
| "v2.6.1" |
There was a problem hiding this comment.
Each release specifies sdk version it's compatible with. Please have a look at the suggestion I've put in another comment.
There was a problem hiding this comment.
"comparibleNcs" is unnecessary at this point. Would you mind removing it, please?
index/dudmuck.json
Outdated
There was a problem hiding this comment.
As @wbober mentioned, this file should be named "semtech.json".
Co-authored-by: Filip Zajdel <[email protected]>
FilipZajdel
requested changes
Aug 29, 2024
index/semtech.json
Outdated
There was a problem hiding this comment.
Hi, please:
- update filename to
Lora-net.json- the filename is then used to fetch the information from the repository to build the index, such as github.com/{organization-name}/{app-name} - modify the file as suggested below - the index file has to conform to this schema
Suggested change
| { | |
| "name": "Semtech", | |
| "description": "LoRa transceiver", | |
| "apps": [ | |
| { | |
| "description": "Software Development Kit featuring demonstrations, drivers and middleware enabling development of connectivity and geolocation applications", | |
| "name": "SWSD006", | |
| "title": "Sidewalk & LoRaWAN Mullti-stack SDK for LR11xx (SWSD006)", | |
| "kind": "sample", | |
| "license": "Apache License 2.0", | |
| "apps": "samples/*", | |
| "releases": [ | |
| { | |
| "date": "2024-08-08T14:30:49Z", | |
| "name": "v2.6.1", | |
| "tag": "v2.6.1", | |
| "sdk": "v2.6.1" | |
| } | |
| ], | |
| "tags": [ | |
| "sidewalk", | |
| "lora-basics-modem", | |
| "CSS", | |
| "FSK" | |
| ] | |
| } | |
| ] | |
| } |
There was a problem hiding this comment.
@dudmuck please incorporate this suggestion.
FilipZajdel
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please add semtech project SWSD006 to ncs app index