-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schema: add compatibleNcs field to schema and filter based on ncs #37
Conversation
VSC-2486 Signed-off-by: Filip Zajdel <[email protected]>
Signed-off-by: Filip Zajdel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the README.md
the new property compatibleNcs
should also be mentioned in this list: https://github.com/nrfconnect/ncs-app-index/blob/main/README.md?plain=1#L44-L51
Signed-off-by: FilipZajdel <[email protected]>
site/public/index.json
Outdated
@@ -0,0 +1,317 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this file added by mistake? Should it be in .gitignore
?
Signed-off-by: Filip Zajdel <[email protected]>
I was hoping that |
I also thought that adding support for specifying semver ranges would be nice, because with it there would be less need to update the And, yes, this gets tricky because tags and branches could really be named anything. An idea:
With this one could e.g. write |
VSC-2486