Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Markdown in description #24

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Support Markdown in description #24

merged 2 commits into from
Nov 3, 2023

Conversation

deerob4
Copy link
Contributor

@deerob4 deerob4 commented Nov 3, 2023

Now e.g. links can be rendered properly. I also updated the Golioth descriptions to use Markdown syntax for links.

image

Copy link
Contributor

@trond-snekvik trond-snekvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -35,6 +35,8 @@
"node-fetch": "^3.3.2",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-markdown": "^9.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, that's a cool component!

@deerob4 deerob4 added this pull request to the merge queue Nov 3, 2023
Merged via the queue into nrfconnect:main with commit d6347e5 Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants