This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Process all image/link URLs during github rewrites #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the first occurrence
|
@revin 👋 I haven't had a chance to dig into this yet, but I'd be interested to see if we can replace the regex with |
|
as an alternative, if we can't, we could switch the recursive step to a stack structure and at least eliminate the chance of a stack overflow. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github URL-rewriting markdown-it plugin was accidentally only doing a single URL replacement per
html_block; this change recursively processes every occurrence instead.Fixes #415.