fix: drop .get / set the sha cache in the operation

npm · Dec 6, 2024 · c41dc4c · c41dc4c
1 parent 47b26a2
commit c41dc4c
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/cli/lib/build.js b/cli/lib/build.js
@@ -120,7 +120,6 @@ const main = async ({loglevel, releases: rawReleases, useCurrent, navPath, conte
     releases.map(r => extractRelease(r, {cache, contentPath, baseNav: navData, prerelease})),
   ).then(r => r.filter(Boolean))
 
-  updates.forEach(r => cache.set(r.id, r.sha))
   await cache.save()
 
   await updateNav(updates, {nav: navDoc, path: navPath})

diff --git a/cli/lib/cache.js b/cli/lib/cache.js
@@ -18,10 +18,6 @@ class CacheVersionSha {
     return this
   }
 
-  get(id) {
-    return this.cache[id]
-  }
-
   set(id, sha) {
     this.cache[id] = sha
     return this

diff --git a/cli/lib/extract.js b/cli/lib/extract.js
@@ -145,6 +145,8 @@ const unpackRelease = async (release, {cache, contentPath, baseNav, prerelease =
     return
   }
 
+  cache.set(release.id, sha)
+
   if (release.prerelease && !prerelease) {
     log.info(`Skipping ${release.id} due to prerelease ${release.version}`)
     return
@@ -225,7 +227,6 @@ const unpackRelease = async (release, {cache, contentPath, baseNav, prerelease =
   return {
     ...release,
     nav: nav.children,
-    sha,
   }
 }