Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user to specify CRL date validity #19

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

nothinux
Copy link
Owner

@nothinux nothinux commented Sep 10, 2023

allow user to specify CRL date validity when revoking certificate and during CA creation

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2023

Codecov Report

Merging #19 (56c15ec) into master (c701791) will increase coverage by 0.11%.
The diff coverage is 87.50%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   70.86%   70.98%   +0.11%     
==========================================
  Files           7        7              
  Lines        1009     1020      +11     
==========================================
+ Hits          715      724       +9     
- Misses        227      228       +1     
- Partials       67       68       +1     
Files Changed Coverage Δ
cmd/certify/main.go 52.00% <ø> (ø)
crl.go 67.60% <50.00%> (ø)
cmd/certify/command.go 69.89% <75.00%> (+0.31%) ⬆️
cmd/certify/helper.go 82.44% <100.00%> (-0.10%) ⬇️

@nothinux nothinux changed the title feat: allow user to specify nextupdate in crl feat: allow user to specify CRL date validity Sep 10, 2023
@nothinux nothinux merged commit 77292e2 into master Sep 10, 2023
4 checks passed
@nothinux nothinux deleted the feat-allow-user-tospecify-nextupdate branch September 10, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants