stb_image_write: fix stbi_write_hdr_to_func undefined when STBI_WRITE_NO_STDIO defined #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craftablescience
changed the title
craftablescience
force-pushed
the
fix/hidden-funcs
branch
2 times, most recently
from
25a2ff7
to
c420269
Compare
|
Fixed the spacing to match code style |
craftablescience
force-pushed
the
fix/hidden-funcs
branch
from
c420269
to
64ea1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
stbi_write_hdr_to_funcis not compiled whenSTBI_WRITE_NO_STDIOis defined, even though the function signature is still present in the header. This appears to be a typo/oversight, and I have changed the location of the #ifndef guard so it matches the other image formats. I have tested this code and the header now compiles withSTBI_WRITE_NO_STDIOwhile usingstbi_write_hdr_to_funcwhere it did not before.