Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stb_image: prevent int to overflow before converting it to size_t #1658

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

stb_image: prevent int to overflow before converting it to size_t #1658

wants to merge 2 commits into from

Conversation

illwieckz
Copy link

@illwieckz illwieckz commented Jun 27, 2024 •
edited
Loading

This fixes some warnings in stb_image_write.h reported by CodeQL:

Multiplication result converted to larger type
Multiplication result may overflow 'int' before it is converted to 'size_t'.

You may find details about the CodeQL reports in the comments made by the github-advanced-security bot in this thread:

@illwieckz illwieckz force-pushed the int-size branch 2 times, most recently from f7b2ecd to d465e7b Compare June 27, 2024 23:44
@illwieckz illwieckz mentioned this pull request Jun 27, 2024
Merged
@illwieckz illwieckz changed the title stb_image_write: prevent int to overflow before converting it to size_t stb_image: prevent int to overflow before converting it to size_t Jul 10, 2024
@illwieckz
Copy link
Author

I added a commit doing the same for stb_image.h.

@illwieckz illwieckz mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illwieckz