Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RGB->BGR channel flipping. First 4 pixels were being skipped. #1647

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryanrsrs
Copy link

@ryanrsrs ryanrsrs commented Jun 6, 2024

Caused first 4 pixels of every line to have bad colors. Not noticable unless the image has bright colors along the left edge.

@jeffrbig2
Copy link

Gad, the scalar paths of the channel flipping weren't being tested. Sorry, will update. What platform were you on that the SIMD path wasn't selected, btw...?

@ryanrsrs
Copy link
Author

ryanrsrs commented Jun 6, 2024

"armv7l" i.e. 32-bit ARM Raspberry Pi Zero 2 W.

Code was compiled with CFLAGS including: -march=native -Os -DSTBIR_USE_FMA -mfpu=neon-vfpv4 -mfp16-format=ieee

Here is my makefile: https://github.com/ryanrsrs/console-jpeg/blob/main/Makefile

I tried with and without -DSTBIR_NO_SIMD, but I think this scalar path was always being used. Should it be NEON?

@jeffrbig2
Copy link

Oh right, that path has no simd path now. Let me do your fix and add one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants