Multiple fixes for ModelList/Download #3034
Draft
+384
−330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc (#2545)" This is what caused regression seen in issue #2943 This reverts commit 30692a2. Signed-off-by: Adam Treat <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
layoutChanged is only used when the *order* changes. When rows are inserted or removed, one of the other three signals is fired. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
The locking strategy used by ModelList assumes that only one thread will be trying to update the model list at a time, as writes cannot be implemented in a fully threadsafe manner. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
Also, hint to layoutChanged about the specific way in which the model was sorted. Signed-off-by: Jared Van Bortel <[email protected]>
dataChanged will not work correctly if we emit it on an old index after sorting. Signed-off-by: Jared Van Bortel <[email protected]>
There were issues with removing clones or models with clones from the model page, as well as trying to remove a model that no longer exists on disk, despite being in settings. These should now be resolved. Signed-off-by: Jared Van Bortel <[email protected]>
This was referenced Oct 5, 2024
Closed
This should always be used instead of joining the current model path setting with the filename, as models may be in subdirectories. But fixing this correctly is not in scope for this PR. Signed-off-by: Jared Van Bortel <[email protected]>
removeModel is starting to make sense now. Signed-off-by: Jared Van Bortel <[email protected]>
- The filename must have a version number, or we will possibly load the cache for the wrong version of GPT4All. - The file should be stored in an appropriate folder for cache, not in the settings location. Signed-off-by: Jared Van Bortel <[email protected]>
Signed-off-by: Jared Van Bortel <[email protected]>
|
waiting for the release!!! |
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Still trying to figure out why I can't delete some models.I can now successfully remove models that are found in subdirectories. Also, the models.json cache location has been changed - it is now stored in a cache folder (not ~/.config), with a version number.
In draft currently because I would like to split this PR into a few different ones.