Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #576 "Upload File Example Broken" #749

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for #576 "Upload File Example Broken" #749

wants to merge 2 commits into from

Conversation

NAM-MAN
Copy link

@NAM-MAN NAM-MAN commented Nov 23, 2019

see #576

Despite the fact that it can be commented that FileObject can be obtained in this line, it was not a valid code, so it was modified.
@coveralls
Copy link

coveralls commented Nov 23, 2019

Coverage Status

Coverage increased (+0.06%) to 96.892% when pulling 41cfefa on NAM-MAN:fix_upload_file_example_broken into 9232e1a on noirbizarre:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 96.782% when pulling c262676 on NAM-MAN:fix_upload_file_example_broken into 9232e1a on noirbizarre:master.

@andreixk
Copy link

@NAM-MAN can you add corresponding unit tests to ensure the changes are covered?

@NAM-MAN
Copy link
Author

NAM-MAN commented Nov 25, 2019

@andreixk
Looking at unittest changed my mind.
In this example, just parse like unittest.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants