Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some _else_condition tech debt #6522

Open
wants to merge 3 commits into
base: jf/fix-bug
Choose a base branch
from

Conversation

TomAFrench
Copy link
Member

@TomAFrench TomAFrench commented Nov 14, 2024

This PR removes the usage of else_condition in Instruction::IfElse

@jfecher note that this is based off of #6434

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Changes to circuit sizes

Generated at commit: 401f7df6b04e04f1149d26e851c6d0affcefeb08, compared to commit: d54b67d64b2e56fe8c9ea817e054f4ea46514449

🧾 Summary (10% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
slice_dynamic_index +4 ❌ +0.32% 0 ➖ 0.00%
hashmap -71 ✅ -0.17% -71 ✅ -0.07%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
slice_dynamic_index 1,261 (+4) +0.32% 6,907 (0) 0.00%
hashmap 41,517 (-71) -0.17% 106,686 (-71) -0.07%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant