Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: try to inline brillig calls with all constant arguments #6466

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

feat: try to inline brillig calls with all constant arguments #6466

wants to merge 18 commits into from

Commits on Nov 5, 2024

  1. Add a skeleton pass to inline const brillig calls

    @asterite
    asterite committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0ba9fb8 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Try to inline brillig calls with all constant arguments

    @asterite
    asterite committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4cf74f6 View commit details
    Browse the repository at this point in the history

  2. Fully copy constants

    @asterite
    asterite committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    726f3bd View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Replace IDs at the end

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    c7dbac1 View commit details
    Browse the repository at this point in the history

  2. Trying something...

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    16dd32f View commit details
    Browse the repository at this point in the history

  3. Found the bug where constants weren't being fully copied from the opt… 

    …imized function
    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dfefc0a View commit details
    Browse the repository at this point in the history

  4. Simplify, and add some comments

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    521d254 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into ab/inline-const-brillig-calls

    @TomAFrench
    TomAFrench authored Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dfd8a19 View commit details
    Browse the repository at this point in the history

  6. Run optimization passes by reusing existing code

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fd15065 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'ab/inline-const-brillig-calls' of github.com:noir-lang/… 

    …noir into ab/inline-const-brillig-calls
    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    df090ef View commit details
    Browse the repository at this point in the history

  8. Remove brillig functions that were inlined everywhere

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    59aed41 View commit details
    Browse the repository at this point in the history

  9. Don't panic on loop unrolling if we can't find an induction variable

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    5a37d5d View commit details
    Browse the repository at this point in the history

  10. Improve comment

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    dd29e65 View commit details
    Browse the repository at this point in the history

  11. Explain why we don't inline

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a68df4c View commit details
    Browse the repository at this point in the history

  12. Turn copy_constant_to_function into a method

    @asterite
    asterite committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    03b4d05 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Introduce OptimizeResult

    @asterite
    asterite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    5298bf3 View commit details
    Browse the repository at this point in the history

  2. More accurate comment regarding main brillig functions

    @asterite
    asterite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    e83fdbd View commit details
    Browse the repository at this point in the history

  3. Introduce UnrollMode to preserve original checks in acir mode

    @asterite
    asterite committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    63aa63d View commit details
    Browse the repository at this point in the history