chore(lsp): Remove profile code lens #6411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
approved these changes
Oct 30, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Oct 31, 2024
…ng/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 1, 2024
…oir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 1, 2024
…ir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 1, 2024
…oir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 1, 2024
fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 2, 2024
…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 2, 2024
feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 3, 2024
…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 3, 2024
feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 4, 2024
…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 4, 2024
feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 4, 2024
…ang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Nov 4, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: nargo command to generate shell completions (noir-lang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]> Co-authored-by: Tom French <[email protected]>
AztecBot
added a commit
to AztecProtocol/aztec-nr
that referenced
this pull request
Nov 5, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: nargo command to generate shell completions (noir-lang/noir#6413) feat: ensure that generated ACIR is solvable (noir-lang/noir#6415) fix: fix Alias and Error kinds (noir-lang/noir#6426) fix: type-check turbofish in trait before function call (noir-lang/noir#6416) chore: create a regression test for #6420 (noir-lang/noir#6421) chore: Release Noir(0.37.0) (noir-lang/noir#6321) chore: update variable names in stdlib tests to be more correct (noir-lang/noir#6419) feat!: remove mimc from stdlib (noir-lang/noir#6402) chore: Replace dead link with updated route in README (noir-lang/noir#6392) feat(ci): Add report of Brillig opcodes executed (noir-lang/noir#6396) feat: improve malformed test attribute error (noir-lang/noir#6414) fix: aliases in path (noir-lang/noir#6399) feat(profiler): Add Brillig procedure info to debug artifact for more informative profiling (noir-lang/noir#6385) chore(lsp): Remove profile code lens (noir-lang/noir#6411) chore(nargo): Remove old profile as part of info cmd (noir-lang/noir#6406) fix: distinguish TypePath with and without turbofish (noir-lang/noir#6404) fix: numeric generic doesn't have a default type (noir-lang/noir#6405) feat: Sync from aztec-packages (noir-lang/noir#6403) chore: add regression tests for #4372 (noir-lang/noir#6401) chore: add regression tests for #6314 (noir-lang/noir#6381) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]> Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
The
Profilecode lens doesn't seem to work when I run it and I do not think it is widely used. The Aztec team exclusively profiles uses thenoir-profilerSummary*
We should lean into the
noir-profiler(#6410). Thus, theProfilecode lens just represents leftover tech debt inside of the lsp crate. Removing this code lens let us remove two dependencies.Example of how the signature of a binary looks now:
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.