Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace to_radix directive with brillig #6386

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves #6302

Summary*

Replace to_radix directive with brillig opcodes

Additional Context

The directive opcode is not removed. It will be removed from AztecPackages once this PR is merged and synced.

This is a draft PR, until the next sync from Aztec Pacakges because it requires AztecProtocol/aztec-packages#9408.

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

Looks like we're falling afoul of us needing to know the size of the return type at compile time but we're only passing this in at runtime.

@TomAFrench
Copy link
Member

@guipublic I've synced from aztec-packages now.

@TomAFrench
Copy link
Member

Looks like this still doesn't work as the linked PR in aztec-packages only handles revert data and not return data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Directive::ToLeRadix
2 participants