Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove aztec compile time feature flag #3596

Merged
merged 45 commits into from
Dec 12, 2023
Merged

chore: remove aztec compile time feature flag #3596

merged 45 commits into from
Dec 12, 2023

Commits on Nov 26, 2023

  1. create a namespaced API for macros

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    6f6217f View commit details
    Browse the repository at this point in the history

  2. remove aztec specific error variants

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    1212b44 View commit details
    Browse the repository at this point in the history

  3. remove aztec feature flag from frontend by allowing arbitrary macro p… 

    …rocessing functions
    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    8373541 View commit details
    Browse the repository at this point in the history

  4. fix test

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f2b128e View commit details
    Browse the repository at this point in the history

  5. add aztec_macro crate

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    413260c View commit details
    Browse the repository at this point in the history

  6. remove aztec feature flag and code from noirc_frontend

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    8282ffe View commit details
    Browse the repository at this point in the history

  7. add aztec feature flag to noirc_driver

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    927a2a3 View commit details
    Browse the repository at this point in the history

  8. modify yml feature flags

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b2fb79a View commit details
    Browse the repository at this point in the history

  9. clippy fix

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f3fa65f View commit details
    Browse the repository at this point in the history

  10. use slice of trait objects when there are no macro processors

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7afdc45 View commit details
    Browse the repository at this point in the history

  11. replace opaque type with trait object in function signature

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7df00c7 View commit details
    Browse the repository at this point in the history

  12. fmt

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    7c9198f View commit details
    Browse the repository at this point in the history

  13. temporarily coerce the type system -- a clone here would likely not b… 

    …e that bad, since each Macro processor is a pointer to a vtable
    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e6b4b89 View commit details
    Browse the repository at this point in the history

  14. fmt

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    89b4678 View commit details
    Browse the repository at this point in the history

  15. use vec instead of slice and clone the pointers to vtable (references… 

    …) -- this should be fairly cheap
    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    00136a1 View commit details
    Browse the repository at this point in the history

  16. fmt

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    cf11ad9 View commit details
    Browse the repository at this point in the history

  17. remove extraneous & in test

    @kevaundray
    kevaundray committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    a925d8d View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. remove aztec feature flag

    @kevaundray
    kevaundray committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    546020d View commit details
    Browse the repository at this point in the history

  2. remove aztec builds from CI workflow

    @kevaundray
    kevaundray committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    958e11f View commit details
    Browse the repository at this point in the history

  3. Update compiler/noirc_driver/Cargo.toml

    @TomAFrench
    TomAFrench authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    0684bf4 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. remove duplicated code

    @kevaundray
    kevaundray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    26559c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into kw/create-api-for-macros

    @kevaundray
    kevaundray authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    c7dd9b9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'kw/create-api-for-macros' into kw/remove-aztec-feature-… 

    …flag
    @kevaundray
    kevaundray authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    7d3f0e1 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into kw/remove-aztec-fea… 

    …ture-flag
    @kevaundray
    kevaundray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    4b64a69 View commit details
    Browse the repository at this point in the history

  5. add aztec macros flag for compiling in typescript

    @kevaundray
    kevaundray committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    d6ebf4f View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. cargo fmt --all

    @kevaundray
    kevaundray committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8c7a7c4 View commit details
    Browse the repository at this point in the history

  2. default to enabling the macro on lsp run

    @kevaundray
    kevaundray committed Nov 29, 2023
    Configuration menu
    Copy the full SHA
    8beb276 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Merge remote-tracking branch 'origin/master' into kw/remove-aztec-fea… 

    …ture-flag
    @kevaundray
    kevaundray committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    79f9afc View commit details
    Browse the repository at this point in the history

  2. fix test

    @kevaundray
    kevaundray committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2c4e84b View commit details
    Browse the repository at this point in the history

  3. fmt

    @kevaundray
    kevaundray committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    f5060a2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into kw/remove-aztec-feature-flag

    @kevaundray
    kevaundray authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    a849a11 View commit details
    Browse the repository at this point in the history

  5. enable aztec macro via an environment variable

    @kevaundray
    kevaundray committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    5746d40 View commit details
    Browse the repository at this point in the history

  6. set the aztec macro based on environment variable for lsp

    @kevaundray
    kevaundray committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1aa2206 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. add missing args

    @kevaundray
    kevaundray committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    58fe17b View commit details
    Browse the repository at this point in the history

  2. lint fix

    @kevaundray
    kevaundray committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    14d846b View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'master' into kw/remove-aztec-feature-flag

    @kevaundray
    kevaundray authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    43a8561 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. Merge branch 'master' into kw/remove-aztec-feature-flag

    @TomAFrench
    TomAFrench authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    d436b0d View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. chore: fix missing arg

    @TomAFrench
    TomAFrench committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f7a8f9f View commit details
    Browse the repository at this point in the history

  2. Empty commit to signal me making changes

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8f99af1 View commit details
    Browse the repository at this point in the history

  3. remove threading of aztec macros flag

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    7f4a1f9 View commit details
    Browse the repository at this point in the history

  4. clippy

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    cb69179 View commit details
    Browse the repository at this point in the history

  5. revert changes

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    97ed2fb View commit details
    Browse the repository at this point in the history

  6. compile no longer needs extra parameter

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9d0e9fd View commit details
    Browse the repository at this point in the history

  7. add disable_macros flag

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    6c266dc View commit details
    Browse the repository at this point in the history

  8. add code to handle disabling macros

    @kevaundray
    kevaundray committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3bb1c2e View commit details
    Browse the repository at this point in the history