Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct handling of unicode in lexer #3335

Merged
merged 1 commit into from Oct 30, 2023
Merged

chore: correct handling of unicode in lexer #3335

merged 1 commit into from Oct 30, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2023

Description

Using Peekable is not the most efficient choice because its "next" function is slower than the underlying iterator's "next," and calling it is a performance bottleneck.

Problem

Resolves #3334

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist\

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kevaundray kevaundray added this pull request to the merge queue Oct 30, 2023
Merged via the queue into noir-lang:master with commit fd017de Oct 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incorrect spans
1 participant