Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove dead code from SSA optimization passes #2800

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

We currently have all dead code lints disabled in noirc_evaluator, ideally we'd remove this in future but we'll have to deal with all these violations first.

This PR removes dead code from the SSA optimization passes.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jfecher jfecher added this pull request to the merge queue Sep 25, 2023
Merged via the queue into master with commit 373325d Sep 25, 2023
27 checks passed
@jfecher jfecher deleted the tf/remove-dead-code-from-opt branch September 25, 2023 13:49
Sakapoi pushed a commit to Sakapoi/noir_fork that referenced this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants