Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Fix version of cross to 0.2.5 #2426

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR updates CI to use cross v0.2.5 rather than building from whatever is currently on the tip of the master branch. This fixes CI failing due to it breaking our MSRV.

Documentation

  • This PR requires documentation updates when merged.

    • I will submit a noir-lang/docs PR.
    • I will request for and support Dev Rel's help in documenting this PR.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from phated August 24, 2023 16:50
@TomAFrench TomAFrench changed the title chore(ci): pin version of cross to 0.2.5 chore(ci): Fix version of cross to 0.2.5 Aug 24, 2023
@TomAFrench TomAFrench added this pull request to the merge queue Aug 24, 2023
Merged via the queue into master with commit d07e041 Aug 24, 2023
19 checks passed
@TomAFrench TomAFrench deleted the cross-version-pinning branch August 24, 2023 17:32
TomAFrench added a commit that referenced this pull request Aug 24, 2023
* master:
  chore(ci): Fix version of `cross` to 0.2.5 (#2426)
  fix: Correct off-by-one errors in lexer spans (#2393)
TomAFrench added a commit that referenced this pull request Aug 24, 2023
* master:
  feat: create equivalence relationships for intermediate witnesses from multiplication (#2414)
  chore(ci): Fix version of `cross` to 0.2.5 (#2426)
  fix: Correct off-by-one errors in lexer spans (#2393)
TomAFrench added a commit that referenced this pull request Aug 24, 2023
* master:
  chore: improve error message for InternalError (#2429)
  chore: Add stdlib to every crate as it is added to graph (#2392)
  feat: create equivalence relationships for intermediate witnesses from multiplication (#2414)
  chore(ci): Fix version of `cross` to 0.2.5 (#2426)
  fix: Correct off-by-one errors in lexer spans (#2393)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants