Skip to content

Commit

Permalink
fix(docs): trigger update-docs workflow when the release-please P…
Browse files Browse the repository at this point in the history
…R gets merged and not on every merge to master (#3677)

# Description

Currently we are triggering the update-docs workflow when there is a
change on the release-please PR branch, this is okay for workflows like
update-lockfile. However, it doesn't work for update-docs because it
uses `needs.release-please.outputs.release-tag-name` which depends on
the release-please tag which we get after we have merged the
release-please PR into master.

See
[here](https://github.com/noir-lang/noir/actions/runs/7024781896/job/19114307821)
for example where update lockfile is ran on master.

## Problem\*

Resolves <!-- Link to GitHub Issue -->

## Summary\*



## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
  • Loading branch information
kevaundray authored Dec 2, 2023
1 parent c00cd85 commit 9a3d1d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
update-docs:
name: Update docs
needs: [release-please, update-lockfile]
if: ${{ needs.release-please.outputs.release-pr }}
if: ${{ needs.release-please.outputs.tag-name }}
runs-on: ubuntu-latest
steps:
- name: Checkout release branch
Expand Down

0 comments on commit 9a3d1d2

Please sign in to comment.