Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Scorecard Report (Manually) #965

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

UlisesGascon
Copy link
Member

Main changes

  • Added updated version for the Scorecard report.
  • This new version includes an alternative way to visualize the reports (new link), thanks @KoolTheba

Context

This is related to #961

Analysis

Key repos

Repository Commit Score Date Difference Report Link StepSecurity Link
nodejs/node 2ac5e98 7.3 2023-04-26T08:57:49Z -0.3 Full Report Fix it
nodejs/security-wg 436ca24 8.2 2023-04-24T22:24:57Z 0.1 Full Report Fix it
nodejs/undici a3efc98 5.7 2023-04-25T10:24:06Z -0.9 Full Report Fix it

Conclusions

  • The biggest different is located in undici, due binary artifacts lib/llhttp/llhttp.wasm & lib/llhttp/llhttp_simd.wasm and code review relatedfound 5 unreviewed human changesets:
  • Node has decreased 0.3 point total, but there are more changes:
    • Reduce scoring scoring due many new binary artifacts in deps/ and test/ folders.
    • Reduce scoring also due code review found 5 unreviewed human changesets
    • Increased due Fuzzing project is fuzzed with [OSSFuzz]
    • Increased due Pinned-Dependencies, still work to do but less than before
    • Increased due no vulnerabilities detected
  • Security-wg has increased 0.1 as we achieve the 30 commits checked:
    • SAST: Info: all commits (30) are checked with a SAST tool
    • CI Test: 30 out of 30 merged PRs checked by a CI test -- score normalized to 10

Additional context

  • link to the StepSecurty Dashboard for Node.js org

@mhdawson
Copy link
Member

@UlisesGascon thanks for the detailed analysis. The ones related to wasm are interesting while most are for tests related to WASM support which I don't think should be flagged, while others are legit things (the wasm used for llhttp).

Do you know if there is a good contact for the scorecard to send feedback to. I think there really should be a configuration list or equivalent that we can exclude the wasm used for tests.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's review it tomorrow

@RafaelGSS RafaelGSS merged commit 648c6a4 into nodejs:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants