Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add a flag v8_enable_simultor #55848

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Nov 14, 2024

The v8 simulator can help we run test or debug non-x64 backend on x64 machine. So I add a flag to build v8 smulator.
For example
build arm64 simulator on x64

 ./configure   --dest-cpu=arm64  --v8-enable-simulator
make 

reopen #50653

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 14, 2024
@luyahan
Copy link
Contributor Author

luyahan commented Nov 14, 2024

Hi @kvakil

I reopen thi pr. Could you have time review this again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants