Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: improve async error performance #53678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fs: improve async error performance #53678

wants to merge 1 commit into from
+335 −290

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jul 1, 2024 •
edited
Loading

Improves async fs functions error performance. This simplifies the codebase a lot and uses less primordials in the process.

If you like my work please sponsor me on https://github.com/sponsors/anonrig.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 1, 2024
@anonrig anonrig requested review from mcollina and lemire July 2, 2024 01:37
@MoLow
Copy link
Member

MoLow commented Jul 2, 2024

can you run a benchmark?

@anonrig
Copy link
Member Author

anonrig commented Jul 2, 2024

can you run a benchmark?

ci is in lockdown. i'm waiting for benchmark ci to be available to share some results.

mcollina
mcollina approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 2, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 3, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60027/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@jasnell jasnell jasnell approved these changes

@lemire lemire Awaiting requested review from lemire

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @MoLow @nodejs-github-bot @mcollina @jasnell