Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: ignore node_trace.*.log #12754

Closed
wants to merge 1 commit into from
Closed

tools: ignore node_trace.*.log #12754

wants to merge 1 commit into from

Conversation

watilde
Copy link
Member

@watilde watilde commented Apr 30, 2017

Refs: #9304

Checklist
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 30, 2017
@watilde watilde added the tools Issues and PRs related to the tools directory. label Apr 30, 2017
ChALkeR
ChALkeR approved these changes Apr 30, 2017
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The commit message should probably have some kind of a description, though, apart from the Refs.

E.g. node_trace.*.log files are generated by NodeTraceWriter or something like that.

@watilde
tools: ignore node_trace.*.log
f4b82ae 
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: nodejs#9304
@watilde
Copy link
Member Author

watilde commented May 1, 2017

Updated the description in the commit message with @ChALkeR 's comment.

@watilde
Copy link
Member Author

watilde commented May 2, 2017 •
edited
Loading

Landed in 678079c

Landed in 595d4ec
(added reviewed-by to the last line quickly...)

@watilde watilde closed this May 2, 2017
@watilde watilde deleted the gitignore-log branch May 2, 2017 04:56
watilde added a commit that referenced this pull request May 2, 2017
@watilde
tools: ignore node_trace.*.log
595d4ec 
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@watilde
tools: ignore node_trace.*.log
3c00325 
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: nodejs#9304
PR-URL: nodejs#12754
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
@watilde @gibfahn
tools: ignore node_trace.*.log
cdd5b52 
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@watilde @gibfahn
tools: ignore node_trace.*.log
eedc87c 
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@watilde @MylesBorins
tools: ignore node_trace.*.log
70e9058 
`node_trace.*.log` files are generated by `NodeTraceWriter`.

Refs: #9304
PR-URL: #12754
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watilde @ChALkeR @jasnell @addaleax @cjihrig @gibfahn @nodejs-github-bot