Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node v20+ #549

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

emptyflask
Copy link

This was added in 9a1cb38 when dropping support for node v19, but I can't see any reason why for instance node v20.5.0 should be excluded.

@aduh95
Copy link
Contributor

aduh95 commented Aug 19, 2024

Does it matter? I think it'd help if you explain your use case.

@emptyflask
Copy link
Author

I have to work with some Ubuntu 20.04 servers that are stuck on node 20.5.1 for some reason. Corepack seems to be compatible with it, so it seems odd to arbitrarily require a specific minor release in the package.json

@aduh95
Copy link
Contributor

aduh95 commented Aug 20, 2024

It's not exactly arbitrary, Node.js 20.5.1 was a current release, and Node.js 20.10.0 was a LTS release. I would encourage you to upgrade, you're behind a few security releases.

If we're making changes, we should also remove changes to Node.js 21.x, and remove the CI job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants