Update github-pages dependency #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated github-pages dependency to work with latest Ruby (2.5.1). This updated the Gemfile.lock, and I made changes to the _config.yml build settings.
implausible
reviewed
Sep 26, 2018
| @@ -49,9 +49,9 @@ other_nodegit_versions: | |||
| - 0.2.7 | |||
|
|
|||
| # Build settings | |||
| markdown: redcarpet | |||
| markdown: kramdown | |||
There was a problem hiding this comment.
Is there any specific reason why we needed to change the markdown or the highlighter settings?
There was a problem hiding this comment.
I was unable to get the website to generate without doing bundle update github-pages because of an error with the json dependency. Bundle updating fixed that error by updating everything in the Gemfile.lock file. The update got rid of redcarpet and pygments, so script/server wouldn't run because of missing dependencies. I googled what the alternatives were, and noticed rouge and kramdown were already in the updated Gemfile.lock. So I changed it in the config file, and script/server ran successfully, letting me generate the website.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated github-pages dependency to work with latest Ruby (2.5.1). This updated the Gemfile.lock, and I made changes to the _config.yml build settings.