Use native URL methods for appending the query params #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Oct 4, 2018
| url.search = FormUrlEncoded.encode(params) | ||
|
|
||
| // combine with any exists query parameters. | ||
| Object.entries(params).map(param => url.searchParams.append(param[0], param[1])) |
There was a problem hiding this comment.
Looks like URLSearchParams encodes it like response_type=id_token+token instead of response_type=id_token%20token. Should be OK per https://stackoverflow.com/a/1211261 or do we need RFC 1738?
kjetilk
added
inrupt-planning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19.
URLSearchParams.append()to append the extra query parameters which also handles theFormUrlEncodedpart.To do