-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic prep #1792
Open
CxRes
wants to merge
8
commits into
nodeSolidServer:main
Choose a base branch
from
CxRes:basic-prep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Basic prep #1792
Commits on Aug 30, 2024
-
Implements Per Resource Events notifications in Node Solid Server. Implementation Notes: + Uses `--experimental-require-module` to load esm packages natively. Requires node > 22.0.0. Start scripts and test invocations have been appropriately modified. + NSS converts strings into an older streaming format which was not being detected by Express-PREP. Express-PREP was modified to ask the user if the body provided is a stream, thus circumventing this issue. + Notifications are triggered from a common middleware, which is invoked after the response has been succesfully sent. + Uses Express PREP supplied default template for notifications.
Configuration menu - View commit details
-
Copy full SHA for 21b15be - Browse repository at this point
Copy the full SHA 21b15beView commit details -
feat: Add Solid-PREP Notifications
Add Solid/Activity Streams format notifications: + Provides notifictions in JSON-LD and Turtle. + Extends notifications to PUT and POST methods. + Add Event-ID header field to the response of a write method.
Configuration menu - View commit details
-
Copy full SHA for f4fb5a0 - Browse repository at this point
Copy the full SHA f4fb5a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 109ce09 - Browse repository at this point
Copy the full SHA 109ce09View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b23e57 - Browse repository at this point
Copy the full SHA 7b23e57View commit details
Commits on Sep 8, 2024
-
fix: Correct Parenting for Solid-PREP Notifications
Parent path is correctly determined only for non root resources. Parent notifications are only generated when resources have a parent.
Configuration menu - View commit details
-
Copy full SHA for 3d93e13 - Browse repository at this point
Copy the full SHA 3d93e13View commit details -
Node 20.17.0 LTS supports require(ESM). Therefore, allowing current Node LTS as well.
Configuration menu - View commit details
-
Copy full SHA for fd99081 - Browse repository at this point
Copy the full SHA fd99081View commit details -
fix: Relax Content-Type Checks in Integration Tests
When checking response `Content-Type` during integration tests, relaxed all media-type values to regex.
Configuration menu - View commit details
-
Copy full SHA for 8021633 - Browse repository at this point
Copy the full SHA 8021633View commit details
Commits on Sep 9, 2024
-
fix: Repository for Surface Tests
Picks the repository from where the PR branch exists.
Configuration menu - View commit details
-
Copy full SHA for e0ebc31 - Browse repository at this point
Copy the full SHA e0ebc31View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.