GET/PATCH for HTML data island in NSS #1715
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourgeoa
changed the title
TallTed
reviewed
Jan 23, 2023
| @@ -128,6 +128,9 @@ async function handler (req, res, next) { | |||
| res.send(data) | |||
| return next() | |||
| } catch (err) { | |||
| if (err.message === '404') { | |||
| return next(error(404, 'HTML do not contain data island')) | |||
There was a problem hiding this comment.
Suggested change
| return next(error(404, 'HTML do not contain data island')) | |
| return next(error(404, 'HTML does not contain any data islands')) |
There was a problem hiding this comment.
The plural in islands seems to allow multiples. Actually my PR only allows one.
Not sure that more than one could be expected. The id="data" cannot be used more than once in an html document.
There was a problem hiding this comment.
There may be multiple islands in a single HTML doc, tho perhaps not (yet) in your environment. My error text is equivalent to saying, "I found no data island in this HTML," among other phrasings.
Another phrasing suggestion might be, HTML does not contain a data island.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the discovery and creation/modification of HTML data island : a script HTML block containing RDF data.
See #1714