-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GET/PATCH for HTML data island in NSS #1715
base: main
Are you sure you want to change the base?
Conversation
@@ -128,6 +128,9 @@ async function handler (req, res, next) { | |||
res.send(data) | |||
return next() | |||
} catch (err) { | |||
if (err.message === '404') { | |||
return next(error(404, 'HTML do not contain data island')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return next(error(404, 'HTML do not contain data island')) | |
return next(error(404, 'HTML does not contain any data islands')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plural in islands
seems to allow multiples. Actually my PR only allows one.
Not sure that more than one could be expected. The id="data"
cannot be used more than once in an html document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There may be multiple islands in a single HTML doc, tho perhaps not (yet) in your environment. My error text is equivalent to saying, "I found no data island in this HTML," among other phrasings.
Another phrasing suggestion might be, HTML does not contain a data island
.
Thanks very much for looking at this. I am very interested in this work. Was it ever tried? If not, I could perhaps try running the branch, to see what it looks like. |
It has been implemented in SolidOS source-pane where you can test it. |
This implements the discovery and creation/modification of HTML data island : a script HTML block containing RDF data.
See #1714