Barclays Cycle Hire Node #87
Conversation
|
You'll need to move your nodes into the ./transport directory. See @hbeeken 's work on the underground node and ensure that you follow her conventions. I did the same for my buses node. Whoever gets in first is to be followed by the rest and regard them as new, accepted conventions. ;) |
| res.on('data', function (chunk) { | ||
| data+= chunk; | ||
| }); | ||
| res.on('end', function() { |
There was a problem hiding this comment.
I think this might be prone to errors too, similarly to your forecast.io node that failed when the server didn't respond as expected. This needs investigation or maybe you could proactively catch exceptions here. In the error scenario, the node should report a visible error to the user (node.error). Input nodes should send no messages, a query node shall simply forward the incoming message.
|
@Raminios , you'll still need to move the node into the ./transport directory. Also, name it "tfl-cyclehire" or similar. Thanks! |
|
@zobalogh Both of these changes have been made? If i click the files changed tab I see all files under transport and using the node name tfl-cyclehire. Is it still necessary for the file names to be tfl-cyclehire? I thought them being in that directory would suffice |
|
@Raminios OK, I looked at my local copy of your repository, sorry. It must be out of date for some reason. I think calling it tfl-cyclehire is better as that name will be included in flows. However this is not "THE" cycle hire node, it's TfL specific. |
Added the barclays cycle hire node. The query node is the intended implementation, the input node is temporary and a full implementation should come after feedback. Feedback/comments welcome!