Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interval property #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

paulvarache
Copy link

I added an interval property to allow the user to choose when the watcher checks for change

@knolleary
Copy link
Member

Hi, thanks for this.

Please have a read of our contributing guide in the main node-red/node-red repository - something we ought to have a version of in this repo.

Essentially, we prefer things to be discussed via issue or mailinglist before a pull-request is raised so that we can agree if the if the desired functionality fits in with what we have planned and what is being worked on.

The bigger item is that we also require a signed contributor agreement before we can accept any PR. Full details in node-red/node-red/CONTRIBUTING.md.

On this specific issue, assuming we resolve the points above, the interval presented to the user should be in minutes - not milliseconds as the underlying code uses.

Let me know how you'd like to proceed.

Nick

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 75.47% when pulling 4056a08 on paulvarache:master into f8650bd on node-red:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants