Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix P04 node naming check #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ralphwetzel
Copy link

In case of a

  • non-legacy node (that is a node registered for the first time after 31.01.2022)
  • having a unscoped name yet conforming to legacy specification

the current implementation

  • issues a warning in combination with setting flag 'test' : false
  • yet then confirms a valid name & sets the 'test' : true flag

This PR alters the sequence of the checks to ensure that non-legacy nodes get flagged as 'test' : false when having an unscoped name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant