Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes up fetch promises. runs code formatter. #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

minaorangina
Copy link
Member

No description provided.

@@ -35,3 +35,5 @@ jspm_packages

# Optional REPL history
.node_repl_history

.prettierrc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit redundant to have this in the .gitignore

Copy link
Member

@claireinez claireinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of console.logs for successes that I don't think need to be in there. We need to think about proper error handling on the front end too, as I've seen quite a few students having to debug on the front end, though that's for a different PR.

console.error(err)
});
.then(function(json) {
console.log(json);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well remove the console.log here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants