Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sharktank] Unpin NumPy on non-Windows #496

Merged
merged 4 commits into from
Nov 14, 2024
Merged

[sharktank] Unpin NumPy on non-Windows #496

merged 4 commits into from
Nov 14, 2024

Conversation

marbre
Copy link
Collaborator

@marbre marbre commented Nov 13, 2024

No description provided.

@marbre
Copy link
Collaborator Author

marbre commented Nov 13, 2024 •
edited
Loading

This Unpining on Windows is blocked by #495, as the underlying issue on Windows was fixed was fixed with torch 2.4.1 (see pytorch/pytorch#131668 (comment)).

@marbre marbre changed the title [sharktank] Unpin numpy [sharktank] Unpin NumPy Nov 13, 2024
@marbre marbre changed the title [sharktank] Unpin NumPy [sharktank] Unpin NumPy on non-Windows Nov 14, 2024
@marbre marbre marked this pull request as ready for review November 14, 2024 13:52
@marbre marbre merged commit 4fcf77b into nod-ai:main Nov 14, 2024
5 checks passed
@marbre marbre deleted the unpin-numpy branch November 14, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marbre @ScottTodd