Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine MISA and Winograd configs #27

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Combine MISA and Winograd configs #27

wants to merge 3 commits into from

Conversation

nithinsubbiah
Copy link
Contributor

@nithinsubbiah nithinsubbiah commented Jun 19, 2024 •
edited
Loading

Use hybrid mode to combine both configs for conv. Reduces the configurations down to:

  1. default
  2. hybrid (misa + winograd)
  3. tk
  4. tk + hybrid

UNet perf with this patch - 56.8ms (tk+hybrid), base - 63.5ms
Verified correctness by generating and comparing the image.

@kuhar kuhar requested a review from RattataKing June 20, 2024 16:24
@kuhar
Copy link
Member

kuhar commented Jun 20, 2024

@RattataKing could you take a look and check if anything in tuning needs to be updated too?

RattataKing
RattataKing reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@RattataKing RattataKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add these new modes to parser arguments in tuning script as a simple update

@kuhar
Copy link
Member

kuhar commented Jun 20, 2024

Let's add this in the same PR. @nithinsubbiah please update the tuning flags too.

@nithinsubbiah
Copy link
Contributor Author

nithinsubbiah commented Jun 20, 2024 •
edited
Loading

Hi @RattataKing, could you add your change and update the PR?

@kuhar
Copy link
Member

kuhar commented Jun 21, 2024

@nithinsubbiah you can cherry-pick this: #29

@RattataKing
Copy link
Contributor

Tested hybrid mode locally and worked well

@RattataKing RattataKing mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RattataKing RattataKing RattataKing approved these changes

@kuhar kuhar kuhar approved these changes

@antiagainst antiagainst Awaiting requested review from antiagainst

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nithinsubbiah @kuhar @RattataKing