[AMD-AIE][ObjectFifo] Address temporary L1 buffers for Matmul+Elem #647
+38
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-- In Matmul+Elemwise we get to see the intermediate L1 buffers for
matmuls :-
alloc -> subview -> access (within amdaie.core)
-- We should replace the subview with a narrowed alloc itself.
-- This commit therefore addresses that as part of
`--iree-amdaie-distribute-cores-and-objectfifos` pass.
Signed-off-by: Abhishek Varma <[email protected]>
Abhishek-Varma
requested review from
MaheshRavishankar,
nirvedhmeshram,
yzhang93 and
jtuyls
as code owners
yzhang93
reviewed
Aug 6, 2024
...er/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/distribute_cores_and_objectfifos.mlir
Outdated
Show resolved
Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEDistributeCoresAndObjectFifos.cpp
Outdated
Show resolved
Hide resolved
yzhang93
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-- In Matmul+Elemwise we get to see the intermediate L1 buffers for matmuls :-
-- We should replace the subview with a narrowed alloc itself.
-- This commit therefore addresses that as part of
--iree-amdaie-distribute-cores-and-objectfifospass.Signed-off-by: Abhishek Varma [email protected]
Addressed sub-action
2from #644