Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHARK-1.0: Fixes to requirements for newer dependency versions #2099

Merged

Conversation

one-lithe-rune
Copy link
Contributor

Motivation

Setting up a venv for SHARK-1.0 was getting to be a right pain, due to #2095 and there apparently no longer being any common torch version that fits both torchvision and the version of torch-mlir we have pinned for SHARK-1.0.

Changes

  • Adds mpmath==1.3.0 as a direct requirement to workaround a sympy dependency issue.
  • Change setup_venv.ps1 to install torchvision --nodeps. This avoids a failure to find any common torch version dependency between the pinned torch-mlir version and torchvision after a long search. This also more closely matches what setup_venv.sh does.

Possible Problems/Concerns

  • Still complains about the dependency conflict around torchvision, but at least it doesn't now check every listed version of torchvision at the index url before giving up.
  • Shouldn't we just pip --freeze everything and pin it all for Shark-1.0,given the current dev effort is all on Studio2/Turbine?

- Adds mpmath==1.3.0 as a direct requirement to workaround a sympy
dependency issue.
- Change setup_venv.ps1 to install torchvision --nodeps. This avoids
a failure to find any common torch version dependency between the
pinned torch-mlir version and torchvision after a long search. This
also more closely matches what setup_venv.sh does.
Copy link
Collaborator

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I haven't been looking at 1.0 but I can't think of any reason not to pin everything.

@monorimet monorimet merged commit bcdcbc6 into nod-ai:SHARK-1.0 Mar 21, 2024
@ameeuwsen
Copy link

I'm still getting some wonkiness around this area. On ./setup_venv.ps1 everything seems to run well except when it comes to pip install torchvision. There seems to be another version clashing. It downgrades torch 2.40. to torch 2.2.0.devxxxx. Error below.

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. torch-mlir 20231210.1048 requires torch==2.2.0.dev20231204, but you have torch 2.4.0 which is incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants