Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relocate quantized matmul reassociation flag #2047

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Conversation

monorimet
Copy link
Collaborator

This flag should be a model/use-case specific addition, not a default CPU compile flag.

We may need to add it to llama2 if it's required for compilation.

This flag should be a model/use-case specific addition, not a default CPU compile flag.
@monorimet monorimet changed the title Remove quantized matmul reassociation flag Relocate quantized matmul reassociation flag Dec 20, 2023
AmosLewis
AmosLewis previously approved these changes Dec 20, 2023
Copy link
Contributor

@AmosLewis AmosLewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monorimet monorimet merged commit fa95ed3 into main Dec 20, 2023
2 checks passed
@monorimet monorimet deleted the monorimet-patch-1 branch December 20, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants