Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Studio 1.0) Setup a separate shark1.venv for Shark-1.0 #2043

Merged
merged 1 commit into from
Dec 17, 2023

Conversation

one-lithe-rune
Copy link
Contributor

This is for the SHARK-1.0 branch only, and any potential branches from that, do not merge into main branch

Motivation

I need a working SHARK 1.0 whilst SHARK 2.0 is being constructed, and I still have the draft of #2015 I'm working on for SHARK 1.0. So I need separate .venvs for main/studio_sd2 and SHARK-1.0 branches.

Having a setup_venv on the SHARK-1.0 branch that creates/maintains a separately named .venv, means I can just run that and not worry I've broken the .venv for the other branches.

Changes

  • Updates setup_venv.ps1 to create and use ./shark1.venv/
  • Updates setup_venv.sh to default to creating ./shark1.venv/

Possible Problems/Concerns

  • I haven't tested the setup_venv.sh change, someone on Linux/Mac will need to check that.
  • I'm assuming we want to keep the main branch .venv as ./shark.venv/
  • I had something much more clever checking git commits and such and deciding which .venv to setup, but then I realised that was pointless, since anything not descended from SHARK-1.0 can just use the current setup_venv unaltered.
  • Still need to remember to activate the right .venv when switching branches (git hook?)

* Updates setup_venv.ps1 to create and use ./shark1.venv/
* Updates setup_venv.sh to default to creating ./shark1.venv/
@one-lithe-rune one-lithe-rune changed the title Setup a separate shark1.venv for Shark-1.0 (Studio 1.0) Setup a separate shark1.venv for Shark-1.0 Dec 16, 2023
Copy link
Collaborator

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@monorimet monorimet merged commit 17dab83 into nod-ai:SHARK-1.0 Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants