Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-1480 Deleting temporary _MEI files #1978

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

KatarinaKubiniova
Copy link

@KatarinaKubiniova KatarinaKubiniova commented Nov 15, 2023

I resolved issue 1480, which is associated with deleting temporary _MEI files. I was unable to find the file containing the unit tests for index.py, so I created a new one. If such a file already exists, please let me know where it is, and I will transfer the tests there.

monorimet
monorimet previously approved these changes Dec 5, 2023
Copy link
Collaborator

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution.

To fix the formatting please run from SHARK repo root:

pip install black

black --line-length 79 ./apps/

@monorimet monorimet dismissed their stale review December 5, 2023 09:41

CI - Lint (see comment on approval)

@KatarinaKubiniova
Copy link
Author

Thank you very much! I've made the formatting changes as requested using black and have pushed the updates.

@monorimet
Copy link
Collaborator

This is going to be lost in the switch to SHARK-2.0 as it targets the old app code. We should add this as a follow-up to the beta release. If you want to land this patch, we should be able to merge it into the SHARK-1.0 branch without conflicts. Otherwise, might need to wait for #2037 as it handles most of the app reimplementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants