Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Minor NFC changes #1711

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NFC] Minor NFC changes #1711

wants to merge 1 commit into from
+0 −21

Conversation

abdulraheembeigh
Copy link

Helping make code clean

@abdulraheembeigh
Copy link
Author

@dan-garvey Please review.

@PhaneeshB
Copy link
Contributor

Thanks for your first contribution @abdulraheembeigh!
Have a nit comment to be addressed.
Also, lint failed on your patch. Use black to line the file
black --line-length 79 <file_path>

@abdulraheembeigh
[NFC] Minor NFC changes
2094511 
Helping make code clean
@abdulraheembeigh
Copy link
Author

abdulraheembeigh commented Aug 7, 2023 •
edited
Loading

Thanks for your first contribution @abdulraheembeigh! Have a nit comment to be addressed. Also, lint failed on your patch. Use black to line the file black --line-length 79 <file_path>

Thank you @PhaneeshB - Made the required change. Please have a look.

@abdulraheembeigh
Copy link
Author

@PhaneeshB Not sure why this is blocked as these are NFC changes that would not hamper/alter functionality. Please let me know what can I do from my end to get this pass. This has been pending for quite some time. It is demotivating. I thought that this is a welcoming repository that cherishes small contributing changes such as NFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulraheembeigh @PhaneeshB