set task_topology_max_group to cpu_count #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powderluv
approved these changes
Jun 26, 2023
powderluv
requested changes
Jun 26, 2023
|
It doesn't work, testing some changes but I hit some failure about local task. Will fix today
…On Mon, Jun 26, 2023, 4:19 AM powderluv ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In shark/iree_utils/cpu_utils.py
<#1594 (comment)>:
> @@ -44,4 +45,12 @@ def get_iree_cpu_args():
error_message = f"OS Type f{os_name} not supported and triple can't be determined, open issue to dSHARK team please :)"
raise Exception(error_message)
print(f"Target triple found:{target_triple}")
- return [f"--iree-llvmcpu-target-triple={target_triple}"]
+ cpu_count = (
+ get_cpu_count()
+ if shark_args.task_topology_max_group_count is None
+ else shark_args.task_topology_max_group_count
+ )
+ return [
+ f"--iree-llvmcpu-target-triple={target_triple}",
+ f"--task_topology_max_group_count={cpu_count}",
+ ]
Does this work though? Isn't it a runtime flag and the target is a compile
time one
—
Reply to this email directly, view it on GitHub
<#1594 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIHDSYGFH7XG5MXB2JBR4WLXNFH3HANCNFSM6AAAAAAZTQLGF4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dan-garvey
force-pushed
the
cpu_count_task_flag
branch
from
51ec733
to
89baefa
Compare
powderluv
previously approved these changes
Jun 26, 2023
dan-garvey
force-pushed
the
cpu_count_task_flag
branch
2 times, most recently
from
f3f6b68
to
eedd9cf
Compare
dan-garvey
force-pushed
the
cpu_count_task_flag
branch
from
eedd9cf
to
0a486a0
Compare
powderluv
reviewed
Jun 26, 2023
dan-garvey
force-pushed
the
cpu_count_task_flag
branch
from
0a486a0
to
7ef518d
Compare
by default. Can be overriden with a flag of the same str
dan-garvey
force-pushed
the
cpu_count_task_flag
branch
from
7ef518d
to
c00b0da
Compare
powderluv
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default. Can be overriden with a flag of the same str