Fix output gallery parameter info when sourcing from .csv and .json formats including VAE & LoRA #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update saving of img_details.csv to include headers for the first row when creating new .csv files. * Update parsing of parameter info by the output gallery from img_details.csv to use headers when they are present * Add VAE and LoRA fields to parameter info in output_gallery when sourced from .csv or .json (was already picked up from .png sources)
powderluv
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1583
Motivation
44a8f2f added VAE & LoRA information to the .png metadata, .json files and the .csv file. The output gallery got the .png metadata updates for 'free' because it can use the same parser as the txt2img image drag and drop UI.
However, the update didn't cover the metadata parsing used by the output gallery to get the parameter information when .png metadata isn't present and it falls back to the .json and csv files.
Changes
img_details.csvto include headers for the first row when creating new .csv files.img_details.csvto use headers when they are present. This and the above should make future updates less painful.Possible Problems/Concerns
imgs_details.csvwill now include headers. That may be a bad assumption.