Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for python version #1570

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Added check for python version #1570

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3c4935
Added check for python version
Ranvirsv Jun 21, 2023
0494555
Merge branch 'main' into python_version_check
Ranvirsv Jun 21, 2023
821fbb7
Update for PYTHON_VERSION_X_Y
Ranvirsv Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions setup_venv.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ PYTHON_VERSION_X_Y=`${PYTHON} -c 'import sys; version=sys.version_info[:2]; prin
echo "Python: $PYTHON"
echo "Python version: $PYTHON_VERSION_X_Y"

if [[ "$(python3 --version 2>&1)" != "Python 3.11"* ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check PYTHON_VERSION_X_Y

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like below if [ "$PYTHON_VERSION_X_Y" == "3.11" ]; then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh okay

echo "Error: Python version 3.11 is required."
exit 1
fi

if [[ "$SKIP_VENV" != "1" ]]; then
if [[ -z "${CONDA_PREFIX}" ]]; then
# Not a conda env. So create a new VENV dir
Expand Down