Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust the margin of the Add block button in the grid layout #4820

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

chenos
Copy link
Contributor

@chenos chenos commented Jul 5, 2024

This is a ...

  • New feature
  • Bug fix
  • Others

Motivation

Description

Showcase

Related issues

Changelog

Language Changelog
🇺🇸 English Adjust the margin of the Add block button in the grid layout
🇨🇳 Chinese 调整网格布局中 Add block 按钮的边距

Checklists

  • All changes have been self-tested and work as expected
  • Test cases are updated/provided or not needed
  • Doc is updated/provided or not needed
  • Component demo is updated/provided or not needed
  • Changelog is provided or not needed
  • Request a code review if it is necessary

This comment has been minimized.

Copy link

github-actions bot commented Jul 5, 2024

Tests results for "E2E"

12 flaky ⚠️ [chromium] › plugins/@nocobase/plugin-workflow/src/client/__e2e__/conditionNode/BranchIntoYesAndNoMathEngine.test.ts:147:5 › Collection event Add Data Trigger, determines that the trigger node integer field variable is equal to an unequal constant, fails.
⚠️ [chromium] › core/client/src/modules/blocks/filter-blocks/__e2e__/schemaInitializer.test.ts:14:7 › where filter block can be added › page
⚠️ [chromium] › plugins/@nocobase/plugin-action-print/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › ReadPrettyFormActionInitializers & CalendarFormActionInitializers should add print action › print action in ReadPrettyFormActionInitializers
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/form/__e2e__/form-create/dragAndDrop.test.ts:12:5 › fields
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/list/__e2e__/schemaInitializer.test.ts:29:7 › where list block can be added › popup
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-edit/src/client/__e2e__/schemaInitailizer.test.ts:14:7 › TableActionInitializers & GanttActionInitializers & MapActionInitializers should add bulk edit action › bulk edit in TableActionInitializers
⚠️ [chromium] › plugins/@nocobase/plugin-auth/src/client/__e2e__/auth.test.ts:21:7 › auth › register
⚠️ [chromium] › plugins/@nocobase/plugin-file-manager/src/client/__e2e__/editLocalStorage.test.ts:15:7 › File manager › edit local storage title
⚠️ [chromium] › core/client/src/modules/blocks/data-blocks/table/__e2e__/schemaSettings1.test.ts:65:9 › table block schema settings › enable drag and drop sorting › enable drag and drop sorting
⚠️ [chromium] › plugins/@nocobase/plugin-acl/src/client/__e2e__/configure.test.ts:13:5 › allows to configure interface
⚠️ [chromium] › plugins/@nocobase/plugin-action-bulk-update/src/client/__e2e__/schemaSettings.test.ts:14:7 › data will be updated && Assign field values && after successful submission › data will be updated && Assign field values && after successful submission
⚠️ [chromium] › pro-plugins/@nocobase/plugin-workflow-approval/src/client/__e2e__/triggerNodeConfig/processConfig/approvalCentreInitiated-DataBlockApproval/withdrawalPermitted.test.ts:177:5 › approval returned

1078 passed, 32 skipped
✔️✔️✔️

Full HTML report. Merge workflow run.

@chenos chenos changed the title fix: improve grid style fix: Adjust the margin of the Add block button in the grid layout Jul 7, 2024
@chenos chenos changed the title fix: Adjust the margin of the Add block button in the grid layout fix: adjust the margin of the Add block button in the grid layout Jul 7, 2024
@chenos chenos merged commit e461189 into main Jul 7, 2024
9 checks passed
@chenos chenos deleted the fix/grid-style branch July 7, 2024 00:34
chenos added a commit that referenced this pull request Jul 7, 2024
)

* fix: improve grid style

* fix: style
# Conflicts:
#	packages/core/client/src/schema-component/antd/page/Page.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant