Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SCHISM submodule and build files #44

Merged
106 commits merged into from
Mar 30, 2022
Merged

add SCHISM submodule and build files #44

106 commits merged into from
Mar 30, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 3, 2021

these changes were manually ported over from https://github.com/pvelissariou1/ADC-WW3-NWM-SCHISM-NEMS/, with commits amended to show authorship to @pvelissariou1 and @platipodium under the email addresses used in the commits

@ghost ghost added the enhancement New feature or request label Jun 3, 2021
@ghost ghost requested review from pvelissariou1 and saeed-moghimi-noaa June 3, 2021 16:30
@ghost ghost self-assigned this Jun 3, 2021
@ghost
Copy link
Author

ghost commented Jun 3, 2021

continuation of #43 , but this one is actually merging into master

@ghost
Copy link
Author

ghost commented Jun 3, 2021

still doing some testing so don't merge just yet

Copy link
Author

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix submodules; the commits to NEMS, SCHISM, and schism-esmf were not pushed, so I need to recreate them

@ghost
Copy link
Author

ghost commented Jun 4, 2021

waiting on schism-dev/schism#31

@ghost
Copy link
Author

ghost commented Jun 4, 2021

pushed commits to submodules, updated submodule pointer to correct commit head

testing build now

@ghost ghost changed the base branch from master to develop March 2, 2022 16:04
@ghost ghost linked an issue Mar 2, 2022 that may be closed by this pull request
9 tasks
zacharyburnett and others added 2 commits March 27, 2022 16:20
# Conflicts:
#	.gitmodules
#	ADCIRC
#	NEMS
@ghost ghost merged commit 9b47de5 into develop Mar 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WW3/SCHSIM integration and CoastalApp pre-requirements
3 participants