Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BrainForced used PRONE instead of DOWN #407

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Fix BrainForced used PRONE instead of DOWN #407

merged 1 commit into from
Oct 14, 2024

Conversation

jokoho48
Copy link
Collaborator

When merged this pull request will:

  1. Fixes Unknown enum value: "PRONE" #406

@jokoho48 jokoho48 self-assigned this Jul 14, 2024
@jokoho48 jokoho48 requested review from diwako and nk3nny July 14, 2024 19:46
@rekterakathom
Copy link
Contributor

I don't know if this pull request is the right place to discuss this, but oh well:

Should this behavior just be removed instead of fixed? Fixing this error will change the behavior of units even though it has been this way for 3 years now, and I don't see anything wrong with the way it has been.

A lot of people (including myself) don't like that the AI goes prone when it shouldn't and I feel like "fixing" this would just increase the amount of weird crawling around that the AI already does.

@Havoc-1
Copy link

Havoc-1 commented Oct 14, 2024

The AI having a sense of self-preservation actually contributes to the gameplay experience positively and I would not mind having this merged with the release branch.

A lot of people (including myself) like the AI going prone when they take fire (just as players do). In the best interest of both parties it might be worth considering to make it togglable via CBA settings to cater to people of different playstyles and preferences.

@diwako
Copy link
Collaborator

diwako commented Oct 14, 2024

Today we will be discussing this PR internally, mostly on the basis of changing the current AI behavior or fixing a long standing bug that was just never caught.

@nk3nny
Copy link
Owner

nk3nny commented Oct 14, 2024

@rekterakathom
The change fixes a bug. It doesn't affect general behaviour, only in a narrow set of circumstances when the AI is in the "attack" fsm (actively hunting a target) and under significant suppression.

This will increase survivability-- but should not affect the AI when clearing rooms or the like.

@jokoho48 jokoho48 merged commit 1a0a0cc into master Oct 14, 2024
4 checks passed
@jokoho48 jokoho48 deleted the DownNotProne branch October 14, 2024 16:08
@jokoho48 jokoho48 added this to the 2.6.1 milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown enum value: "PRONE"
5 participants